Added an optional display title for the notification panel on Android #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. If a title is not specified, the URL or filename value is used instead (as previously).
|
this one is really useful feature. Can this be merged pls. |
|
@hnvn Is there any reason why this is not merged. It would be useful to lot of users. |
|
@amugofjava Please resolve the merge conflicts, then we can merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At present, the notification panel on Android shows either the URL or filename of the file being downloaded. These values are not always very useful friendly, so I have added an optional title parameter to allow the user to specify a more friendly display value for the download. If the title is not specified, the URL or filename is displayed as before.